Skip to content

Fail the UprootRaw_Dict example if the server returns unexpected values #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2025
Merged

Fail the UprootRaw_Dict example if the server returns unexpected values #678

merged 1 commit into from
Oct 31, 2025

Conversation

@ponyisi
Copy link
Collaborator

@ponyisi ponyisi commented Oct 31, 2025

@ponyisi ponyisi marked this pull request as ready for review October 31, 2025 01:41
@codecov
Copy link

codecov bot commented Oct 31, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.17%. Comparing base (fda0311) to head (dbc5fd6).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #678   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files          29       29           
  Lines        2081     2081           
=======================================
  Hits         2043     2043           
  Misses         38       38
Flag Coverage Δ
unittests 98.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ponyisi ponyisi temporarily deployed to production-service October 31, 2025 01:42 — with GitHub Actions Inactive
BenGalewsky
BenGalewsky approved these changes Oct 31, 2025
View reviewed changes
Copy link
Contributor

@BenGalewsky BenGalewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@BenGalewsky BenGalewsky merged commit fcc1909 into master Oct 31, 2025
44 checks passed
@BenGalewsky BenGalewsky deleted the louder-smoke branch October 31, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenGalewsky BenGalewsky BenGalewsky approved these changes

@gordonwatts gordonwatts Awaiting requested review from gordonwatts

@MattShirley MattShirley Awaiting requested review from MattShirley

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ponyisi @BenGalewsky